Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampers - Sara S - Media Ranker Revisited #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ampers - Sara S - Media Ranker Revisited #30

wants to merge 7 commits into from

Conversation

CheerOnMars
Copy link

No description provided.

@CheezItMan
Copy link

CheezItMan commented May 2, 2018 •
edited
Loading

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController Nothing done here
Appropriate Tests on SessionsController It doesn't look like you've done much here.
Appropriate Tests on UsersController Nothing done here
Completed OAuth You need some sort of filter to prevent guest users from getting into areas they shouldn't be. Most importantly, you don't have OAuth working here!
Overall You don't have the Omniauth gems in your Gemfile. So I couldn't run the app without fixing it.

CheezItMan
CheezItMan reviewed May 2, 2018
View reviewed changes
test/controllers/sessions_controller_test.rb

describe "logout" do
it 'succeeds at if no user' do
get logout_path
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no get route for logout. It's a delete route

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheerOnMars @CheezItMan